Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MakeValid() from MSSQL Driver #5856

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Remove MakeValid() from MSSQL Driver #5856

merged 1 commit into from
Sep 9, 2019

Conversation

geographika
Copy link
Member

These calls as disable spatial indexes causing a performance hit.
See post in mailing list.

szekerest
szekerest approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@szekerest szekerest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct at this stage.
Regarding to the extent calculation by removing MakeValid the EnvelopeAggregate will likely fail on any invalid geometries in the table, so the user should fix them before using the table in mapserver.

@szekerest
Copy link
Member

We may also backport this to the 7-4 branch.

@geographika geographika added the backport branch-7-4 To backport a pull request to branch-7-4 label Sep 9, 2019
@geographika geographika merged commit 0f31eda into MapServer:master Sep 9, 2019
@backporting backporting bot mentioned this pull request Sep 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szekerest szekerest szekerest approved these changes

Assignees
No one assigned
Labels
backport branch-7-4 To backport a pull request to branch-7-4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geographika @szekerest