Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to PROJ 6 API #5888

Merged
merged 18 commits into from Oct 10, 2019
Merged

Port to PROJ 6 API #5888

merged 18 commits into from Oct 10, 2019

Conversation

@rouault
Copy link
Contributor

rouault commented Oct 1, 2019

No description provided.

rouault added 18 commits Aug 23, 2019
…aring
…PROJ6 related)
… lossy PROJ4 strings
…th PROJ 4 and PROJ 6)
…/MapScript requests of the same thread
…ect.dat. The envelope in the GDAL TIFF file defers to micrometer depending on the exact PROJ transformation path
@rouault rouault merged commit 346c167 into mapserver:master Oct 10, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rouault rouault mentioned this pull request Nov 3, 2019
@geographika

This comment has been minimized.

Copy link
Member

geographika commented Nov 20, 2019

Hi @rouault - I see there are some FastCGI related changes as part of this.

I made a new build from master and I'm getting HTTP 500 errors on IIS. The only information I can get from the failed request tracing is The system cannot open the file. (0x4).
The error happens even with an empty request (no Mapfile or data involved) - it should return No query information to decode. QUERY_STRING is set, but empty.
I've checked a few things with process explorer but there are no obvious errors.
If I test with a Mapfile it successfully queries a database but won't return any data via IIS.

From the command line, and also when using the CgiModule rather than FastCgiModule in IIS everything works fine.

I also downloaded a master build from https://www.gisinternals.com/development.php and it has the same issue when running under FastCGI.

Any ideas on what may be the cause? I can take to the mailing list if more appropriate.

@rouault

This comment has been minimized.

Copy link
Contributor Author

rouault commented Nov 20, 2019

I see there are some FastCGI related changes as part of this.

In the code you mean ? In theory no. mapserv.c which is where FCGI specific code is hasn't been touched. Commit f595e91 is indeed supposed to help for FCGI code or Python WSGI + MapServer. That said, I'm not sure I tested FCGI after my changes

@rouault

This comment has been minimized.

Copy link
Contributor Author

rouault commented Nov 20, 2019

OK, I've just test mapserver master against a PROJ 5 and PROJ 6 builds, with Apache and FastCGI under Linux, and it works fine...

@geographika

This comment has been minimized.

Copy link
Member

geographika commented Nov 20, 2019

@rouault - thanks for the update. I've looked through some other recent commits and nothing stands out. Simply switching from FastCgi to Cgi and everything works, so it doesn't appear to be a dependency issue. I'll try compiling with USE_PROJ set to false to see if that works.

@rouault

This comment has been minimized.

Copy link
Contributor Author

rouault commented Nov 20, 2019

you could also try git bisect to find the offending commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.