New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing an interface for MapViewPosition #1044

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mikes222
Contributor

mikes222 commented Mar 15, 2018

introducing an interface for MapViewPosition. The alternative implementation of MapViewPosition is already included but not yet fully working with that checkin. In order to get it working we need to adapt the interface a bit. But that is a story for a different pull-request.

introducing an interface for MapViewPosition. Preparing for a differe…
…nt implementation of MapViewPosition which is already included but not yet fully working with that checkin.

@devemux86 devemux86 added this to the 0.10.0 milestone Mar 16, 2018

devemux86 added a commit that referenced this pull request Mar 16, 2018

devemux86 added a commit that referenced this pull request Mar 16, 2018

@devemux86

This comment has been minimized.

Collaborator

devemux86 commented Mar 16, 2018

Thanks!

Rebased and merged via cd50e01.

New class is MapViewPosition2 but remains a placeholder (extending regular), since it didn't actually work, could not even zoom. So once having a working implementation can be placed in there.

With 70c2778 I pushed:

  • MapViewPosition2 can be enabled simply via:
Parameters.MAP_VIEW_POSITION2 = true;
  • Plus a new MapViewPosition2Viewer example in Android samples.

Some general remarks:

  • Better use a topic branch for pull requests for easier maintenance.
  • Pull requests must be (re)based on latest master before submit (this one was quite old).

@devemux86 devemux86 closed this Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment