Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POI writer: add optional support to create tag with normalize-name #1123

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@KamikX
Copy link
Contributor

commented Jul 1, 2019

This change add support for PoiWriter.java class to create normalize-name from name value designed for accent-insensitive search by name. Command line parameter is described in POI.md

KamikX added some commits Jun 30, 2019

@devemux86 devemux86 added this to the 0.12.0 milestone Jul 3, 2019

@devemux86 devemux86 changed the title Add optional support to create tag with normalize-name POI writer: add optional support to create tag with normalize-name Jul 3, 2019

// If normalize names is enabled and key == name
if (t.getKey().toLowerCase(Locale.ENGLISH).equals("name") && configuration.isNormalizeNames()) {
//LOGGER.info("Normalize name...");
String normalizeNameValue = deAccent(t.getValue().toLowerCase());

This comment has been minimized.

Copy link
@devemux86

devemux86 Jul 3, 2019

Collaborator

Using default locale in toLowerCase may produce unexpected results.

devemux86 added a commit that referenced this pull request Jul 3, 2019

@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Thanks, merged via ca9f1d1.

@devemux86 devemux86 closed this Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.