New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hillshading update: filtered upscaling on android, smooth tile borders #997

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@usrusr
Contributor

usrusr commented Oct 4, 2017

Updates to #923 hillshading, the seams reported by @demiantres should be addressed by this, amongst others.
The biggest changes:

  1. Filtered upscaling on android (using a questionably arcane way, but more straight-forward approaches failed to give filtered upscaling on my test Z1c)
  2. Perfect (as far as i can tell?) alignment at tile borders
  3. Optional interpolation padding at hillshading tile borders to get rid of interpolation artifacts. Unfortunately it is very slow on android (first map tile rendered after five hgt tiles are loaded instead of after one hgt), it might be faster to just merge the border pixels on the go into a four pixels wide temporary bitmap that is painted separately (as a two-hillpixels wide piece)
  4. An "always" attribute in the hillshading theme element that causes flat shading to be applied whenever hgt files are missing or hillshading is not enabled, so that themes can compensate for desaturation
hillshading update: filtered upscaling on android, smooth tile borders
hillshading update: filtered upscaling on android, smooth tile borders
@devemux86

This comment has been minimized.

Show comment
Hide comment
@devemux86

devemux86 Oct 5, 2017

Collaborator

Thanks, nice work!

Merged via c691e71.

Collaborator

devemux86 commented Oct 5, 2017

Thanks, nice work!

Merged via c691e71.

@devemux86 devemux86 closed this Oct 5, 2017

@devemux86

This comment has been minimized.

Show comment
Hide comment
@devemux86

devemux86 Oct 5, 2017

Collaborator

BTW in Desktop Samples skipped the -restore for simplicity, as was saving already the model, so only the check on open was needed.

Collaborator

devemux86 commented Oct 5, 2017

BTW in Desktop Samples skipped the -restore for simplicity, as was saving already the model, so only the check on open was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment