Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of new features not possible in ZL 18 and above #216

Closed
Klaus-Tockloth opened this issue Oct 29, 2016 · 11 comments

Comments

@Klaus-Tockloth
Copy link

commented Oct 29, 2016

It seems that isn't possible to introduce new map feature in zoomlevel above 17.

This works:

    <m e="way" k="building" v="gebaeude_allgemein" closed="yes" zoom-min="17">
        <caption k="addr:housenumber" style="normal" size="11" fill="#333333" stroke="#00123456" stroke-width="1.0" />
    </m>

This didn't:

    <m e="way" k="building" v="gebaeude_allgemein" closed="yes" zoom-min="18">
        <caption k="addr:housenumber" style="normal" size="11" fill="#333333" stroke="#00123456" stroke-width="1.0" />
    </m>

Peculiar ...

@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Oct 29, 2016

MapFileTileSource has a default max zoom level 17.
Related zoom conversation in opensciencemap#122.

@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Oct 29, 2016

@hjanetzek 's change from max zoom 18 is in opensciencemap@3178787.

@Klaus-Tockloth

This comment has been minimized.

Copy link
Author

commented Oct 30, 2016

There is a relation to issue #217

@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Oct 30, 2016

MapFileTileSource's default max zoom level 17 is for data extraction.
Map view can zoom further using that data, e.g. zoom 20 and beyond.

@devemux86 devemux86 added the bug label Oct 30, 2016
@devemux86 devemux86 modified the milestone: 0.7.0 Oct 30, 2016
@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Oct 30, 2016

Actually the reason for this issue seems to be #219.
Permitting MapFileTileSource reading also from zoom 18 can solve this, but with other problems (see opensciencemap#122).

@braandl

This comment has been minimized.

Copy link

commented Nov 2, 2016

There is another issue with Mapsforge Mapfiles and zl >= 18. Using Float Datatypes in the Projection Code causes the renderer to genereate hugh round-off errors. Changing all lat-lon related datatypes to double fixes a whole lot of this errors and does not cost too much performance on newer smartphones.

I did write a patch for this (schudt@739941b) but it is not well tested so far.

@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Nov 2, 2016

There is more, e.g. core classes like GeoPoint and BoundingBox use integers for their coordinates.
(in Mapsforge we use everywhere doubles without issues)

So shouldn't we start from those first and then proceed with other areas of the library?

@braandl if you want to submit a pull request on latest master, I can merge it in a separate branch.
Data types is a very important change and would need extremely good testing.

@hjanetzek any particular reason for using integers (or it's an Osmdroid influence)?

@braandl

This comment has been minimized.

Copy link

commented Nov 2, 2016

@devemux86 Ok, I will create a Pull-Request. I did run my configuration with a mapsforge file and the visual render quality is way better!
But the Issues from opensciencemap#122 are not resolved with this.

@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Nov 2, 2016

First screenshots in opensciencemap#122 probably refer to an old Mapsforge issue with grid artifacts on zooms 12-13.
See here for discussion and here for a solution involving different map creation.

@braandl

This comment has been minimized.

Copy link

commented Nov 2, 2016

Thank you! I will look into that :-) I did create a pull-request with the datatype changes.

@devemux86

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2017

Closing as #231 is no blocker anymore, just need to use MapFileTileSource(0, 18) or larger.

For overzoom, i.e. separation of data extraction and rendering, there is #393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.