Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes XML pull parser #431

Closed
devemux86 opened this issue Oct 25, 2017 · 8 comments
Closed

Themes XML pull parser #431

devemux86 opened this issue Oct 25, 2017 · 8 comments
Milestone

Comments

@devemux86
Copy link
Collaborator

@devemux86 devemux86 commented Oct 25, 2017

VTM uses XML push parsing (SAX) for themes, which can be slow and with less performance for large map styles, waiting for the whole theme to build up.

We can integrate also kXML2 XML pull parser, which is small / fast and well tested in Mapsforge, with the XML rules accessible immediately when they are available.

Furthermore it's based on the common XML pull API, so we can plug any platform pull parser (see mapsforge/mapsforge#974).

@andreynovikov
Copy link

@andreynovikov andreynovikov commented Oct 25, 2017

I have a high demand for a parser that supports xi:include instruction. Do you know any? Built-in Android implementation does not support it. It looks like kXML2 does not support it too.

Loading

@devemux86
Copy link
Collaborator Author

@devemux86 devemux86 commented Oct 25, 2017

Loading

@andreynovikov
Copy link

@andreynovikov andreynovikov commented Oct 25, 2017

Yes

Loading

@devemux86
Copy link
Collaborator Author

@devemux86 devemux86 commented Oct 31, 2017

We could activate XInclude processing, but that only works on Desktop Java, the Android SAXParserFactoryImpl doesn't supports it.

Loading

@andreynovikov
Copy link

@andreynovikov andreynovikov commented Nov 14, 2017

I know, that's why I would be happy if it will be substituted with anything that supports it.

Loading

@drakkan
Copy link

@drakkan drakkan commented Dec 9, 2018

this feature would be very useful to use OpenAndroMaps theme

Loading

@devemux86
Copy link
Collaborator Author

@devemux86 devemux86 commented Aug 1, 2019

Can discuss in forum and if there is interest from community to contribute.

Loading

@devemux86 devemux86 closed this Aug 1, 2019
@devemux86 devemux86 added this to the 0.15.0 milestone Sep 25, 2020
devemux86 added a commit that referenced this issue Sep 25, 2020
@devemux86
Copy link
Collaborator Author

@devemux86 devemux86 commented Sep 25, 2020

Implemented in #786.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants