New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes XML pull parser #431

Open
devemux86 opened this Issue Oct 25, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@devemux86
Collaborator

devemux86 commented Oct 25, 2017

VTM uses XML push parsing (SAX) for themes, which can be slow and with less performance for large map styles, waiting for the whole theme to build up.

We can integrate also kXML2 XML pull parser, which is small / fast and well tested in Mapsforge, with the XML rules accessible immediately when they are available.

Furthermore it's based on the common XML pull API, so we can plug any platform pull parser (see mapsforge/mapsforge#974).

NOTE:
Since it's a core change, it should be added as an extra option.
We should keep current classes / implementation unmodified for compatibility.

@andreynovikov

This comment has been minimized.

Show comment
Hide comment
@andreynovikov

andreynovikov Oct 25, 2017

I have a high demand for a parser that supports xi:include instruction. Do you know any? Built-in Android implementation does not support it. It looks like kXML2 does not support it too.

andreynovikov commented Oct 25, 2017

I have a high demand for a parser that supports xi:include instruction. Do you know any? Built-in Android implementation does not support it. It looks like kXML2 does not support it too.

@devemux86

This comment has been minimized.

Show comment
Hide comment
@devemux86
Collaborator

devemux86 commented Oct 25, 2017

@andreynovikov

This comment has been minimized.

Show comment
Hide comment
@andreynovikov

andreynovikov commented Oct 25, 2017

Yes

@devemux86

This comment has been minimized.

Show comment
Hide comment
@devemux86

devemux86 Oct 31, 2017

Collaborator

We could activate XInclude processing, but that only works on Desktop Java, the Android SAXParserFactoryImpl doesn't supports it.

Collaborator

devemux86 commented Oct 31, 2017

We could activate XInclude processing, but that only works on Desktop Java, the Android SAXParserFactoryImpl doesn't supports it.

@andreynovikov

This comment has been minimized.

Show comment
Hide comment
@andreynovikov

andreynovikov Nov 14, 2017

I know, that's why I would be happy if it will be substituted with anything that supports it.

andreynovikov commented Nov 14, 2017

I know, that's why I would be happy if it will be substituted with anything that supports it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment