Automapping follow-ups (error message and documentation) #1001

Open
sjaakd opened this Issue Dec 19, 2016 · 4 comments

Projects

None yet

4 participants

@sjaakd
Contributor
sjaakd commented Dec 19, 2016 edited

Follow up of #60:

  • create a dotted path notation for error messages where nested properties can't be mapped automatically
  • Adapt reference documentation
  • Add entry to migration notes to note that there won't be an error message in case nested properties can be mapped automatically
  • Make sure that configuration from prototype methods in @MapperConfig classes are applied to forged methods (I think that's currently not the case and never has been -- but we should tackle that soon as it becomes more important now)
  • TestMultipleForgedMethodsTest needs to do some assertions: create proper input data and assert the results. Rename the test class itself (Test*Test) and rename the classes Bar, BarDto, Dto... :)
  • Should work for update methods too
@sjaakd sjaakd referenced this issue Dec 19, 2016
Closed

#60 Automapping #937

@agudian agudian changed the title from Automapping, handle dotted messages for missing mappings. to Automapping follow-ups (error message and documentation) Dec 19, 2016
@navpil
Contributor
navpil commented Dec 21, 2016

How should we continue on this?
I already have some changes, which work, but they break some tests, which assume another format of the error message. But before I fix those tests I'd better know that the format I chose is the correct one. Should I do the PR with some tests failing so you can look at the current implementation (I have a dedicated test for these error messages)? Should we discuss it in the google group? Should we discuss it here?

@agudian
Member
agudian commented Dec 21, 2016

I'd say open a new PR right away and we can discuss it there directly with the modified code and the failing tests visible to all of us... :)

@gunnarmorling
Member
@agudian
Member
agudian commented Dec 23, 2016

I've added another point about the test class TestMultipleForgedMethodsTest that I just stumbled upon... It looks a bit unfinished... 😉

@agudian agudian added this to the 1.2.x milestone Dec 23, 2016
@sjaakd sjaakd added a commit to sjaakd/mapstruct that referenced this issue Jan 8, 2017
@sjaakd sjaakd #1001 auto mapping support for update methods fd2ea9b
@sjaakd sjaakd added a commit to sjaakd/mapstruct that referenced this issue Jan 9, 2017
@sjaakd sjaakd #1001 auto mapping support for update methods test 84322db
@sjaakd sjaakd added a commit to sjaakd/mapstruct that referenced this issue Jan 9, 2017
@sjaakd sjaakd #1001 auto mapping support for update methods solution b38c2d6
@sjaakd sjaakd added a commit to sjaakd/mapstruct that referenced this issue Jan 11, 2017
@sjaakd sjaakd #1001 auto mapping support for update methods 779b420
@sjaakd sjaakd added a commit to sjaakd/mapstruct that referenced this issue Jan 11, 2017
@sjaakd sjaakd #1001 auto mapping support for update methods dafdcfc
@sjaakd sjaakd added a commit to sjaakd/mapstruct that referenced this issue Jan 12, 2017
@sjaakd sjaakd #1001 auto mapping support for update methods 0188dcb
@navpil navpil added a commit to navpil/mapstruct that referenced this issue Jan 17, 2017
@navpil navpil #1001 Dotted error messages 6256661
@navpil navpil added a commit to navpil/mapstruct that referenced this issue Jan 17, 2017
@navpil navpil #1001 Dotted error messages 3273825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment