New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 9 Automatic Module Name in Manifest #1224

Closed
filiphr opened this Issue Jun 13, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@filiphr
Member

filiphr commented Jun 13, 2017

Is this something that we want for 1.2.0.Final or we should do it in the next release?

@filiphr filiphr added this to the 1.2.0.Final milestone Jun 13, 2017

@gunnarmorling

This comment has been minimized.

Show comment
Hide comment
@gunnarmorling

gunnarmorling Jun 13, 2017

Member

Let's do it if there's a Java 9 build supporting that header available at the time of the release.

Member

gunnarmorling commented Jun 13, 2017

Let's do it if there's a Java 9 build supporting that header available at the time of the release.

@jodastephen

This comment has been minimized.

Show comment
Hide comment
@jodastephen

jodastephen Jun 20, 2017

No need to wait for a Java 9 build now, the spec looks pretty set in stone.

Where I do have concerns with a quick look is that the Java code in the core, core-jdk8 and core-common folders all have the same package name. If these are built into separate jar files, then they cannot be separate modules, because a package can only be allocated to one module.

jodastephen commented Jun 20, 2017

No need to wait for a Java 9 build now, the spec looks pretty set in stone.

Where I do have concerns with a quick look is that the Java code in the core, core-jdk8 and core-common folders all have the same package name. If these are built into separate jar files, then they cannot be separate modules, because a package can only be allocated to one module.

@gunnarmorling

This comment has been minimized.

Show comment
Hide comment
@gunnarmorling

gunnarmorling Jun 20, 2017

Member

Yes, not much risk to adding the header righ away, I guess.

If these are built into separate jar files

Users will only either depend on core or core-jdk8. core-common is pulled into the other two at build time of MapStruct (we use it to share common code between these two flavors of the MapStruct API JAR). So people won't end up with multiple modules containing the org.mapstruct package unless there's something wrong with their module path setup.

Member

gunnarmorling commented Jun 20, 2017

Yes, not much risk to adding the header righ away, I guess.

If these are built into separate jar files

Users will only either depend on core or core-jdk8. core-common is pulled into the other two at build time of MapStruct (we use it to share common code between these two flavors of the MapStruct API JAR). So people won't end up with multiple modules containing the org.mapstruct package unless there's something wrong with their module path setup.

@gunnarmorling

This comment has been minimized.

Show comment
Hide comment
@gunnarmorling

gunnarmorling Jun 27, 2017

Member

Java 9 b175 is out by now which supports the Automatic-Module-Name header. We're already making use of it in Bean Validation and Hibernate Validator.

Member

gunnarmorling commented Jun 27, 2017

Java 9 b175 is out by now which supports the Automatic-Module-Name header. We're already making use of it in Bean Validation and Hibernate Validator.

@gunnarmorling gunnarmorling self-assigned this Jul 8, 2017

@gunnarmorling gunnarmorling modified the milestones: 1.2.0.CR1, 1.2.0.Final Jul 8, 2017

gunnarmorling added a commit to gunnarmorling/mapstruct that referenced this issue Jul 8, 2017

@agudian

This comment has been minimized.

Show comment
Hide comment
@agudian

agudian Jul 8, 2017

Member

Gunnar fixed it, thanks! 👍

Member

agudian commented Jul 8, 2017

Gunnar fixed it, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment