Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Java 9 Automatic Module Name in Manifest #1224
No need to wait for a Java 9 build now, the spec looks pretty set in stone.
Where I do have concerns with a quick look is that the Java code in the core, core-jdk8 and core-common folders all have the same package name. If these are built into separate jar files, then they cannot be separate modules, because a package can only be allocated to one module.
Yes, not much risk to adding the header righ away, I guess.
Users will only either depend on core or core-jdk8. core-common is pulled into the other two at build time of MapStruct (we use it to share common code between these two flavors of the MapStruct API JAR). So people won't end up with multiple modules containing the