#1164 Make sure that all import types of a Type are imported for the wrapper #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the wrapper
|
👍 Feel free to merge! |
|
Thanks for the review @agudian. Once the build is done I will merge it. Can you also have a look at the issue. It looks like the code generated in 1.0.0.Final is not the same as in 1.1.0.Final, and I am not sure what is correct :). It looks like for |
I think Sjaak fixed some stuff there and the change was intentional (didn't we even have something about that in the migration notes?)... |
|
@agudian Thanks again for the review. I have merged it to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164