Dev #436
Merged
Dev #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix small bugs in project creation
Fix groups with no tasks
…rint Feature smaller task size footprint
This was referenced Oct 26, 2020
| center_x = feature.GetFieldAsDouble("center_x") | ||
| center_y = feature.GetFieldAsDouble("center_y") | ||
| groups[group_id_string]["center_points"].append([center_x, center_y]) | ||
| except: # noqa |
Contributor
There was a problem hiding this comment.
flake8 raises an issue not to use bar except statements. If the error type is known it should be used instead. But I am not sure which error would be raised by GetFieldAsDouble if the key is not found.
Probably KeyError.
Member
Author
There was a problem hiding this comment.
yep, I also was not sure which error will be raised, since this will come from gdal/ogr and this is always a bit complicated
mapswipe_workers/mapswipe_workers/project_types/arbitrary_geometry/task.py
Outdated
Show resolved
Hide resolved
mapswipe_workers/mapswipe_workers/utils/tile_grouping_functions.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.