New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixeleted overzoom on hillshading #1

Open
klokan opened this Issue Aug 17, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@klokan
Copy link
Collaborator

klokan commented Aug 17, 2018

According to mapbox/mapbox-gl-js#6027, the pixelated over zooming should be fixed now...
35676073-1375705e-0753-11e8-8f39-eac8cefd6252
36191385-8c080894-1165-11e8-81c7-6307a65b2fc0

What do we have to do with maxzoom?

@petrsloup

This comment has been minimized.

Copy link
Collaborator

petrsloup commented Sep 18, 2018

Is it possible that there are some issues with the data itself?

See https://labs.maptiler.com/terrain-demos/hypsometry/#12/46.69/8.92 and switch to the lowres.
image

The lines are clearly visible in the OpenLayers as well, it's possible, that the hillshading algorithm just makes them more visible.

@jachym

This comment has been minimized.

Copy link

jachym commented Jan 10, 2019

This is, how the input data look like
obrazek

There is no sign of anything strange in the data

This is, how the data look like when hillshade applied using gdaldem hillshade

obrazek

Again, the result is quite ok to me.

@halset

This comment has been minimized.

Copy link

halset commented Jan 10, 2019

@jachym is that with zoom less or more than maxzoom of the dem layer?

@jachym

This comment has been minimized.

Copy link

jachym commented Jan 10, 2019

This is, how the input data look like - you can see each pixel. We are going to interpoloate input data with better resolution and see, if it helps for the shading.

@jachym

This comment has been minimized.

Copy link

jachym commented Jan 10, 2019

@petrsloup sample data are store on gdrive Terrain:dem-lowres/tmp/

Generated with

gdalwarp -co COMPRESS=DEFLATE -r bilinear -tr 0.0010415 0.0010415  dem-lowres_5_45.tiff dem-lowres_5_45-zoom-bilinear.tiff

and

docker  run --rm  -ti -v $(pwd):/data -e MAPTILER_LICENSE=XXX maptiler/engine maptiler -store mbtiles -scale 2 -f png -zoom 0 +1 -name "\"DEM Lowres 5_45 -zoom 0 +1 -tr 0.0010415 \"" -o /data/dem-lowres_5_45-zoom.mbtiles dem-lowres_5_45-zoom-bilinear.tiff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment