Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflected XSS vulnerability in the application main page #461

Closed
joohoi opened this issue Jul 1, 2020 · 0 comments
Closed

Reflected XSS vulnerability in the application main page #461

joohoi opened this issue Jul 1, 2020 · 0 comments

Comments

@joohoi
Copy link

joohoi commented Jul 1, 2020

Hi, I stumbled upon a reflected XSS in the software.

It stems from reflecting unsanitized user controller input directly to the HTTP response.

I initially observed this in Tileserver GL 2.5, but from the looks of it it's still present in the current master.

Vulnerable request example:

https://example.org/?key=%22%3E%3Cscript%3Ealert%281%29%3B%3C%2Fscript%3E

The code in question is here https://github.com/maptiler/tileserver-gl/blob/master/src/server.js#L322-L323

petrsloup added a commit that referenced this issue Jul 2, 2020
Fix reflected XSS in 'key' parameter. Fixes #461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant