Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes body data from http 204 response #339

Merged
merged 1 commit into from Jan 7, 2019
Merged

Removes body data from http 204 response #339

merged 1 commit into from Jan 7, 2019

Conversation

ibesora
Copy link
Contributor

@ibesora ibesora commented Jan 7, 2019

The HTTP 1.1 specification states the following on the 204 No content status code definition:

The 204 response MUST NOT include a message-body, and thus is always
terminated by the first empty line after the header fields.

Some Vector Tile libraries (at least Mapbox GL Native and Mapbox GL React Native) throw an error if a body message is present on an HTTP response with the 204 status code. This PR removes the body message from the response when an HTTP 204 response is sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants