New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard accessible layer options #306

Merged
merged 10 commits into from Jun 3, 2018

Conversation

Projects
None yet
1 participant
@orangemug
Copy link
Member

orangemug commented May 22, 2018

Added additional menu into <LayerEditor/>. This is to make the following options accessible to keyboard users

  • reorder layers (previously only via drag)
  • duplicate layer
  • delete layer
  • hide/show layer

I've hidden the icons (delete/duplicate/hide) in the layers list view from the keyboard. The reason being is that I'm aiming to switch to an accessible tree view for the layers list. I believe trying to add in keyboard support for sub items of a treeview would be confusing for the user and difficult to develop. These are now also in the 'vertical ellipsis menu' on the layer pane.

screen shot 2018-05-28 at 12 32 52

I've also added a header describing the pane (Layer: [id]) which I'm unsure about.

Looking for feedback (CC @gregorywolanski, @pathmapper)

Note: The main objective here is accessibility for keyboard users.

You can see a demo at https://456-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html

orangemug added some commits May 22, 2018

Added additional menu in <LayerEditor/>
This is to make the following options accessible to keyboard users

 - reorder layers
 - duplicate layer
 - delete layer
 - hide/show layer

@orangemug orangemug referenced this pull request May 22, 2018

Closed

Accessibility #295

11 of 25 tasks complete

orangemug added some commits May 28, 2018

@orangemug

This comment has been minimized.

Copy link
Member

orangemug commented Jun 3, 2018

Merging this PR, any objections to the UI please raise a new ticket.

@orangemug orangemug merged commit edd09ef into maputnik:master Jun 3, 2018

8 checks passed

ci/circleci: build-linux-node-v10 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-node-v6 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-node-v8 Your tests passed on CircleCI!
Details
ci/circleci: build-osx-node-v10 Your tests passed on CircleCI!
Details
ci/circleci: build-osx-node-v6 Your tests passed on CircleCI!
Details
ci/circleci: build-osx-node-v8 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@orangemug orangemug referenced this pull request Jul 11, 2018

Closed

Release v1.3.0 #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment