Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to remove auth requirement #46

Merged
merged 7 commits into from Jun 30, 2016

Conversation

migurski
Copy link

@migurski migurski commented Jun 29, 2016

  • Seems to work.
  • Cleaning up some tests.
  • Post it someplace for QA.
  • Get feedback.

Closes #32.

@migurski migurski self-assigned this Jun 29, 2016
@migurski
Copy link
Author

@bcamper / @louh, this is something you guys have been asking about for some time. Mind testing it at https://mapzen-precog-noauth.herokuapp.com with a few Tangram use cases?

@louh
Copy link

louh commented Jun 29, 2016

Works for me. Tangram Play use case:

This fails in Precog because Tangram Play makes uncredentialed requests for local scene files: https://precog.mapzen.com/tangrams/tangram-play/no-auth-precog-test/

This works on the no-auth server:
https://mapzen-precog-noauth.herokuapp.com/tangrams/tangram-play/no-auth-precog-test/

@migurski
Copy link
Author

Excellent! I’ll move forward with this; might require some additional tinkering because I needed to comment out one test to get it to work. 😶

@migurski migurski merged commit 4dcd19a into master Jun 30, 2016
@migurski migurski deleted the 32-migurski-remove-auth-requirement branch June 30, 2016 05:59
This was referenced Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants