Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

* Fix for reviews with design users who no longer exist (problem on m…

…aqetta.org for guest account users who invited real users to reviews resulting in a 500 error in listVersions)
  • Loading branch information...
commit fa58fe5d49570eca03381174182bf6b3b52504f9 1 parent fe7c389
bradley childs authored
View
2  maqetta.core.server/src/maqetta/core/server/command/ListVersions.java
@@ -37,6 +37,8 @@ public void handleCommand(HttpServletRequest req, HttpServletResponse resp, IUse
String reviewTime = reviewerVersion.getTimeVersion();
if (designerIDParm == null || designerIDParm.equals("") || designerIDParm.equals(reviewDesignerID)) {
IDesignerUser designerUser = commentingManager.getDesignerUser(reviewDesignerID);
+ /* designer user removed from the system (or never existed) */
+ if(designerUser==null) continue;
Version version = designerUser.getVersion(reviewTime);
if (version != null) {
View
2  maqetta.core.server/src/maqetta/core/server/user/ReviewManager.java
@@ -223,6 +223,8 @@ public IDesignerUser getDesignerUser(String name) {
IDesignerUser designer = designerUsers.get(name);
if (designer == null) {
IUser user = ServerManager.getServerManger().getUserManager().getUser(name);
+
+ if(user==null) return null;
designer = getDesignerUser(user);
}
return designer;
Please sign in to comment.
Something went wrong with that request. Please try again.