[TweetView] iphone.css and claro.css don't work well together #2194

Closed
doronrosenberg opened this Issue May 7, 2012 · 15 comments

Comments

Projects
None yet
5 participants
@doronrosenberg

The issue in TweetView with the tabbar cutting of label text is due to claro.css setting a line-height on all li nodes.

@jhpedemonte @JonFerraiolo @peller

Can we disable claro.css from loading when we are in mobile mode? This probably affects other mobile widgets as well and not just tabbar.

@ghost ghost assigned billreed63 May 7, 2012

@JonFerraiolo

This comment has been minimized.

Show comment
Hide comment
@JonFerraiolo

JonFerraiolo May 7, 2012

Member

-> @billreed63 who is the theme set meister

Member

JonFerraiolo commented May 7, 2012

-> @billreed63 who is the theme set meister

@jhpedemonte

This comment has been minimized.

Show comment
Hide comment
@jhpedemonte

jhpedemonte May 7, 2012

Member

Are we still adding claro.css all the time now? That should come from metadata, shouldn't it? The mobile widgets don't depend on claro.css.

Member

jhpedemonte commented May 7, 2012

Are we still adding claro.css all the time now? That should come from metadata, shouldn't it? The mobile widgets don't depend on claro.css.

@billreed63

This comment has been minimized.

Show comment
Hide comment
@billreed63

billreed63 May 7, 2012

Member

We are still adding claro by default, we still need to address how to get default desktop theme's from toolkits

Member

billreed63 commented May 7, 2012

We are still adding claro by default, we still need to address how to get default desktop theme's from toolkits

@JonFerraiolo

This comment has been minimized.

Show comment
Hide comment
@JonFerraiolo

JonFerraiolo May 7, 2012

Member

@peller
The problem in this case is that we are merging dojo.css into claro.css. It's dojo.css that provides generic styling for HTML elements.

Member

JonFerraiolo commented May 7, 2012

@peller
The problem in this case is that we are merging dojo.css into claro.css. It's dojo.css that provides generic styling for HTML elements.

@peller

This comment has been minimized.

Show comment
Hide comment
@peller

peller May 7, 2012

Member

@JonFerraiolo where do we merge dojo.css and claro.css? I see two distinct @import statements in the user files.

Member

peller commented May 7, 2012

@JonFerraiolo where do we merge dojo.css and claro.css? I see two distinct @import statements in the user files.

@JonFerraiolo

This comment has been minimized.

Show comment
Hide comment
@JonFerraiolo

JonFerraiolo May 7, 2012

Member

@billreed63 do you know? (my best two guesses: (1) we create a built version of claro.css manually, (2) our build process creates a built version of claro.css)

Member

JonFerraiolo commented May 7, 2012

@billreed63 do you know? (my best two guesses: (1) we create a built version of claro.css manually, (2) our build process creates a built version of claro.css)

@JonFerraiolo

This comment has been minimized.

Show comment
Hide comment
@JonFerraiolo

JonFerraiolo May 7, 2012

Member

I think I found the culprit. Look at maqetta.core.client/WebContent/dijit/themes/claro/document.css. It imports dojo.css.

update Wait, I don't see who imports document.css, so maybe that's not the culprit afterall.

update The Dijit oam files all include dojo.css. I don't think that's right. Maybe we did that as a temporary hack once upon a time and now it has come back to bite us? @jhpedemonte

update
I haven't figured out yet how dojo.css gets built into claro.css, but I'm certain that's what is happening. If you look at the user document, there is no LINK element for dojo.css, and if you look at the Style panel for IconContainer's LI elements, you'll see a rule in claro.css that matches exactly the rule in dojo.css.

Member

JonFerraiolo commented May 7, 2012

I think I found the culprit. Look at maqetta.core.client/WebContent/dijit/themes/claro/document.css. It imports dojo.css.

update Wait, I don't see who imports document.css, so maybe that's not the culprit afterall.

update The Dijit oam files all include dojo.css. I don't think that's right. Maybe we did that as a temporary hack once upon a time and now it has come back to bite us? @jhpedemonte

update
I haven't figured out yet how dojo.css gets built into claro.css, but I'm certain that's what is happening. If you look at the user document, there is no LINK element for dojo.css, and if you look at the Style panel for IconContainer's LI elements, you'll see a rule in claro.css that matches exactly the rule in dojo.css.

@peller

This comment has been minimized.

Show comment
Hide comment
@peller

peller May 8, 2012

Member

When I look at user source, I do see an @import for dojo.css, also for claro.css. When I look at the claro.css content, I do not see anything that resembles dojo.css.

Member

peller commented May 8, 2012

When I look at user source, I do see an @import for dojo.css, also for claro.css. When I look at the claro.css content, I do not see anything that resembles dojo.css.

@peller

This comment has been minimized.

Show comment
Hide comment
@peller

peller May 8, 2012

Member

@JonFerraiolo which rule do you see in claro.css that's suspect?

Member

peller commented May 8, 2012

@JonFerraiolo which rule do you see in claro.css that's suspect?

@JonFerraiolo

This comment has been minimized.

Show comment
Hide comment
@JonFerraiolo

JonFerraiolo May 8, 2012

Member

which rule do you see in claro.css that's suspect?

Look at davinci.dojo_1_7/WebContent/maqetta/themes/claro/claro.css:1715. Those CSS rules are part of dojo.css. When I add an IconContainer and look at the LI nodes for IconContainer in the debugger, I see these rules (from dojo.css) applied to LI, and browser says the rules are coming from claro.css:1715.

Member

JonFerraiolo commented May 8, 2012

which rule do you see in claro.css that's suspect?

Look at davinci.dojo_1_7/WebContent/maqetta/themes/claro/claro.css:1715. Those CSS rules are part of dojo.css. When I add an IconContainer and look at the LI nodes for IconContainer in the debugger, I see these rules (from dojo.css) applied to LI, and browser says the rules are coming from claro.css:1715.

@peller

This comment has been minimized.

Show comment
Hide comment
@peller

peller May 8, 2012

Member

Wow.

Ok, well looking at the Dojo releases, dojo.css hasn't been directly @imported into the theme files since Dojo 1.5. @billreed63 do we just need to update this file? I seem to remember us updating these copies of the theme files on multiple occasions, but maybe it got lost in one of the moves?

Member

peller commented May 8, 2012

Wow.

Ok, well looking at the Dojo releases, dojo.css hasn't been directly @imported into the theme files since Dojo 1.5. @billreed63 do we just need to update this file? I seem to remember us updating these copies of the theme files on multiple occasions, but maybe it got lost in one of the moves?

@billreed63

This comment has been minimized.

Show comment
Hide comment
@billreed63

billreed63 May 8, 2012

Member

If I remember correctly claro was updated when we updated the toolkit to 1.7. The version that was added to the maqetta themes was a built version to improve network performance, maybe the build process imports dojo.css

So say we remove dojo.css from claro don't we still have an issue if we mix desktop widget and mobile on a page.

If the page is mobile do we add claro but not dojo.css, and for desktop we add claro and dojo.css. We do not have this capability at present

Member

billreed63 commented May 8, 2012

If I remember correctly claro was updated when we updated the toolkit to 1.7. The version that was added to the maqetta themes was a built version to improve network performance, maybe the build process imports dojo.css

So say we remove dojo.css from claro don't we still have an issue if we mix desktop widget and mobile on a page.

If the page is mobile do we add claro but not dojo.css, and for desktop we add claro and dojo.css. We do not have this capability at present

@peller

This comment has been minimized.

Show comment
Hide comment
@peller

peller May 8, 2012

Member

I remember updating too, but you may want to try again. claro.css hasn't referenced dojo.css since Dojo 1.5. Even after a build process, claro.css should not have dojo.css content, so I'm wondering if we have the 1.5 version checked in.

Member

peller commented May 8, 2012

I remember updating too, but you may want to try again. claro.css hasn't referenced dojo.css since Dojo 1.5. Even after a build process, claro.css should not have dojo.css content, so I'm wondering if we have the 1.5 version checked in.

@JonFerraiolo

This comment has been minimized.

Show comment
Hide comment
@JonFerraiolo

JonFerraiolo May 8, 2012

Member

Maybe all we need to do is overwrite the version at davinci.dojo_1_7/WebContent/maqetta/themes/claro/claro.css with the version found at davinci.dojo_1_7/WebContent/dojo/dijit/themes/claro/claro.css. (Also check mobile themes)

Member

JonFerraiolo commented May 8, 2012

Maybe all we need to do is overwrite the version at davinci.dojo_1_7/WebContent/maqetta/themes/claro/claro.css with the version found at davinci.dojo_1_7/WebContent/dojo/dijit/themes/claro/claro.css. (Also check mobile themes)

@peller

This comment has been minimized.

Show comment
Hide comment
@peller

peller May 9, 2012

Member

yes, that's what I suggest. We should probably do a more careful cleanup of the entire dir.

Member

peller commented May 9, 2012

yes, that's what I suggest. We should probably do a more careful cleanup of the entire dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment