New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ProofOfExistence translatable #1

Closed
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mapmeld
Contributor

mapmeld commented Feb 21, 2014

Uses the strategy described here for translations on AppEngine + Jinja: http://mikeshilkov.wordpress.com/2012/07/26/enable-jinja2-and-i18n-translations-on-google-appengine/

Translating.md describes how to update and add new translations: https://github.com/mapmeld/proofofexistence/blob/translatable/translating.md

  • Adds babel and gaepytz libraries (this is why it is such a big PR)
  • Adds a few sample translations (Spanish) in locale/es/LC_MESSAGES/messages.po
  • Add a translation.js for messages in JavaScript
  • Set language based on user selection, URL, cookie, or language sent to server (in that order)

You can try it out on http://map-poe.appspot.com?lang=es - I do not know enough to translate much, but you can see it on the homepage and about.

@maraoz

This comment has been minimized.

Show comment
Hide comment
@maraoz

maraoz Feb 21, 2014

Owner

Thanks for contributing! My code is horrible yet, I hope you didn't find it too troublesome (I haven't publicized the source code yet because I wanted to tidy things up). I'll check your Pull Request and merge it if everything is OK.

Owner

maraoz commented Feb 21, 2014

Thanks for contributing! My code is horrible yet, I hope you didn't find it too troublesome (I haven't publicized the source code yet because I wanted to tidy things up). I'll check your Pull Request and merge it if everything is OK.

@maraoz

This comment has been minimized.

Show comment
Hide comment
@maraoz

maraoz Feb 21, 2014

Owner

By the way: did you make the whole site work on your deployed version? (like, coinbase integration, etc). If you did I admire you, it's totally undocumented and config is not trivial 👍

Owner

maraoz commented Feb 21, 2014

By the way: did you make the whole site work on your deployed version? (like, coinbase integration, etc). If you did I admire you, it's totally undocumented and config is not trivial 👍

@mapmeld

This comment has been minimized.

Show comment
Hide comment
@mapmeld

mapmeld Feb 21, 2014

Contributor

No problem!

My deployment does not actually work - I just created a secrets.py where everything is an empty string

Contributor

mapmeld commented Feb 21, 2014

No problem!

My deployment does not actually work - I just created a secrets.py where everything is an empty string

@mapmeld

This comment has been minimized.

Show comment
Hide comment
@mapmeld

mapmeld Mar 1, 2014

Contributor

If you separate out the babel and gaepytz folders and download those directly from their repos, the rest of the changes should be more digestable.

Contributor

mapmeld commented Mar 1, 2014

If you separate out the babel and gaepytz folders and download those directly from their repos, the rest of the changes should be more digestable.

@mapmeld

This comment has been minimized.

Show comment
Hide comment
@mapmeld

mapmeld Mar 22, 2014

Contributor

would it be helpful to integrate the translations currently in the JS into the .PO side?

Contributor

mapmeld commented Mar 22, 2014

would it be helpful to integrate the translations currently in the JS into the .PO side?

@maraoz

This comment has been minimized.

Show comment
Hide comment
@maraoz

maraoz Mar 22, 2014

Owner

Nick, sorry. I've been very busy with other stuff and wasn't able to try
and merge your pull request. Next week I'll give it a try :)
On Mar 22, 2014 2:09 AM, "Nick Doiron" notifications@github.com wrote:

would it be helpful to integrate the translations currently in the JS into
the .PO side?

Reply to this email directly or view it on GitHubhttps://github.com/maraoz/proofofexistence/pull/1#issuecomment-38343299
.

Owner

maraoz commented Mar 22, 2014

Nick, sorry. I've been very busy with other stuff and wasn't able to try
and merge your pull request. Next week I'll give it a try :)
On Mar 22, 2014 2:09 AM, "Nick Doiron" notifications@github.com wrote:

would it be helpful to integrate the translations currently in the JS into
the .PO side?

Reply to this email directly or view it on GitHubhttps://github.com/maraoz/proofofexistence/pull/1#issuecomment-38343299
.

@mapmeld

This comment has been minimized.

Show comment
Hide comment
@mapmeld

mapmeld Mar 23, 2014

Contributor

I made the change anyway - should be a lot cleaner to have translations in one place.

I updated http://map-poe.appspot.com so you can see it working there.

Contributor

mapmeld commented Mar 23, 2014

I made the change anyway - should be a lot cleaner to have translations in one place.

I updated http://map-poe.appspot.com so you can see it working there.

@maraoz

This comment has been minimized.

Show comment
Hide comment
@maraoz

maraoz Mar 26, 2014

Owner

Can you rebase, please?

git remote add maraoz git@github.com:maraoz/proofofexistence.git
git pull --rebase maraoz master
# fix conflicts if any
Owner

maraoz commented Mar 26, 2014

Can you rebase, please?

git remote add maraoz git@github.com:maraoz/proofofexistence.git
git pull --rebase maraoz master
# fix conflicts if any

@mapmeld mapmeld closed this Mar 27, 2014

@mapmeld mapmeld referenced this pull request Mar 27, 2014

Merged

Make translatable #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment