Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameter ending on '.com' returns download/error #145

Closed
SORC3r3r opened this issue Jun 17, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@SORC3r3r
Copy link

commented Jun 17, 2019

Describe the bug
I am using marblejs in one of my applications and encountered a weird behaviour if I send a query looking like this GET 127.0.0.1:1337?userId=test@test.com.
Turns out that it breaks because of the .com at the end of the query.
I would like to consume a JSON file there, but somehow it is always interpreted with an application/x-msdownload header and results my application to return a 500 HTTP error.
I used your "hello world" example to reproduce it.

To Reproduce
Setup the "hello world" example.
Do a request like this GET 127.0.0.1:1337?userId=test@test.com.
Receive a download file called download.exe

Expected behavior
Do not interpret the request as a download request.

Desktop (please complete the following information):

  • OS: macOS Mojave Version 10.14.4
  • marblejs@2.2.2
  • Node version 8.15.10

@SORC3r3r SORC3r3r changed the title Query parameter ending on `.com` returns download/error Query parameter ending on '.com' returns download/error Jun 17, 2019

@JozefFlakus JozefFlakus self-assigned this Jun 18, 2019

@JozefFlakus JozefFlakus added this to the 2.2.3 milestone Jun 18, 2019

@JozefFlakus

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Thanks for spotting this bug! Fixed in v2.2.3

@SORC3r3r

This comment has been minimized.

Copy link
Author

commented Jun 24, 2019

Nice! Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.