Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-JSON return types #33

Closed
couzic opened this issue May 28, 2018 · 3 comments

Comments

Projects
2 participants
@couzic
Copy link

commented May 28, 2018

I'm trying to serve static files with Marble, but it does not seem possible because of a JSON.stringify() applied to every outgoing response:
https://github.com/marblejs/marble/blob/master/packages/core/src/response/response.handler.ts

It would make sense (simplest solution I could think) to stringify objects only, not strings.

Also, taking into account headers provided in the EffectResponse object could be of value.

@JozefFlakus

This comment has been minimized.

Copy link
Member

commented May 28, 2018

Thanks, will fix it in the nearest patch release 👍

@JozefFlakus JozefFlakus added this to the v3.0.2 milestone May 28, 2018

@JozefFlakus JozefFlakus added this to To do in Roadmap to 1.0.0 via automation May 28, 2018

@JozefFlakus

This comment has been minimized.

Copy link
Member

commented May 29, 2018

@couzic We've just released version 0.3.2 with bugfix/improvement for this issue. See changelog: https://github.com/marblejs/marble/releases/tag/v0.3.2

Big thanks for detecting this issue 💪

Roadmap to 1.0.0 automation moved this from To do to Done May 29, 2018

@couzic

This comment has been minimized.

Copy link
Author

commented May 29, 2018

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.