Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply one and only one effect #35

Closed
couzic opened this issue May 29, 2018 · 3 comments

Comments

Projects
2 participants
@couzic
Copy link

commented May 29, 2018

When I have two effects, matching:
/user/search
/user/:id

Both effects get applied, resulting in:
Error: Can't set headers after they are sent.

It would make sense to have only one effect applied, intuitively that would be the first one in effects array.

@JozefFlakus JozefFlakus added the bug label May 29, 2018

@JozefFlakus

This comment has been minimized.

Copy link
Member

commented May 29, 2018

@couzic thanks for submitting an issue. We will definitely take care of this 💪

@JozefFlakus JozefFlakus added this to the v3.0.2 milestone May 29, 2018

@JozefFlakus JozefFlakus added this to To do in Roadmap to 1.0.0 via automation May 29, 2018

@JozefFlakus JozefFlakus modified the milestones: v0.3.2, v0.3.3 May 29, 2018

@JozefFlakus JozefFlakus moved this from To do to In progress in Roadmap to 1.0.0 May 30, 2018

@JozefFlakus JozefFlakus modified the milestones: v0.3.3, v0.4.0 May 30, 2018

@JozefFlakus

This comment has been minimized.

Copy link
Member

commented May 30, 2018

@couzic fixed in version 0.4.0. You can check latest changelog here: marblejs.gitbook.io/marble/changelog

Thanks again for the support! 💪

Roadmap to 1.0.0 automation moved this from In progress to Done May 30, 2018

@couzic

This comment has been minimized.

Copy link
Author

commented May 31, 2018

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.