Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@marblejs/core is missing chalk dependency #77

Closed
goulderb opened this issue Nov 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@goulderb
Copy link

commented Nov 5, 2018

Describe the bug
The @marblejs/core package utilizes chalk in the error/error.factory.js file. This is not listed as a required dependency, which causes the installed dependencies to be incorrect when this is installed in production mode (npm i --production). This causes any marblejs application to crash since the package cannot be imported.

To Reproduce
Create a boilerplate server with @marblejs/core and install dependencies via npm i --production with no pre-existing node_modules.

Expected behavior
I expect the chalk dependency to be added to the @marblejs/core package.

Desktop (please complete the following information):

  • OS: Mac OS X High Sierra
  • Package + Version: @marblejs/core v1.2.0
  • Node version: v10.13.0
@JozefFlakus

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

Thanks for detecting this issue! Fixed in version v1.2.1 💪

@JozefFlakus JozefFlakus added this to the 1.2.1 milestone Nov 5, 2018

@JozefFlakus JozefFlakus added the bug label Nov 5, 2018

@JozefFlakus JozefFlakus self-assigned this Nov 5, 2018

@JozefFlakus JozefFlakus closed this Nov 5, 2018

@JozefFlakus JozefFlakus added this to the 1.2.1 milestone Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.