Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-body): application/x-www-form-urlencoded #101

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
3 participants
@JozefFlakus
Copy link
Member

commented Feb 4, 2019

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • @marblejs/middleware-body doesn't parse application/x-www-form-urlencoded body types

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JozefFlakus JozefFlakus added the bug label Feb 4, 2019

@JozefFlakus JozefFlakus added this to the 2.0.0-rc.1 milestone Feb 4, 2019

@JozefFlakus JozefFlakus self-assigned this Feb 4, 2019

@JozefFlakus JozefFlakus added this to In progress in @marblejs/next via automation Feb 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #101 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           next   #101   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        77     77           
  Lines       962    962           
  Branches     85     85           
===================================
  Hits        962    962
Impacted Files Coverage Δ
...ckages/core/src/+internal/http/contentType.util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d383ae7...4dd4458. Read the comment docs.

@marblejs/next automation moved this from In progress to Reviewer approved Feb 4, 2019

@JozefFlakus JozefFlakus merged commit 935e362 into next Feb 4, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details

@marblejs/next automation moved this from Reviewer approved to Done Feb 4, 2019

@JozefFlakus JozefFlakus deleted the fix/next/bodyParser branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.