Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(http helper): simplified `createHttpRequest` function and it's usages #140

merged 1 commit into from Jun 6, 2019


None yet
2 participants
Copy link

commented Jun 6, 2019

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

You have to pass url whenever you use createHttpRequest function. The function is only used for testing purposes.

What is the new behavior?

Internally in createHttpRequest function, the defaults are set in a bit better way. Also, it does accept empty/partial object and still falls back to the right default values.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I also updated usages of the method in all tests.

@krzysztof-miemiec krzysztof-miemiec requested a review from JozefFlakus Jun 6, 2019

@krzysztof-miemiec krzysztof-miemiec self-assigned this Jun 6, 2019


This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
  Coverage   99.06%   99.06%           
  Files         109      109           
  Lines        1286     1286           
  Branches      128      128           
  Hits         1274     1274           
  Misses         10       10           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdc83d...150839e. Read the comment docs.

@JozefFlakus JozefFlakus merged commit d59c939 into master Jun 6, 2019

2 checks passed

Travis CI - Pull Request Build Passed
codecov/patch Coverage not affected when comparing 1cdc83d...150839e

@JozefFlakus JozefFlakus deleted the imp/http-helper branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.