Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): request url parse error #147

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@JozefFlakus
Copy link
Member

commented Jun 18, 2019

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Server returns 500 status code when query parameters contains URL-like value

Issue Number: #145

What is the new behavior?

Server reacts correctly when an URL ends with .whatever (eg. user@email.com)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JozefFlakus JozefFlakus added the bug label Jun 18, 2019

@JozefFlakus JozefFlakus added this to the 2.2.3 milestone Jun 18, 2019

@JozefFlakus JozefFlakus requested a review from krzysztof-miemiec Jun 18, 2019

@JozefFlakus JozefFlakus self-assigned this Jun 18, 2019

@JozefFlakus JozefFlakus force-pushed the fix/145/request-url-parse-error branch from bb58391 to a8f5a37 Jun 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #147 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   92.14%   92.15%   +<.01%     
==========================================
  Files         125      125              
  Lines        1693     1695       +2     
  Branches      172      173       +1     
==========================================
+ Hits         1560     1562       +2     
  Misses        131      131              
  Partials        2        2
Impacted Files Coverage Δ
packages/core/src/response/response.handler.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3854b1f...8bd572e. Read the comment docs.

@JozefFlakus JozefFlakus force-pushed the fix/145/request-url-parse-error branch from a8f5a37 to 8bd572e Jun 18, 2019

@JozefFlakus JozefFlakus merged commit 3bdae24 into master Jun 20, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 92.14%)
Details

@JozefFlakus JozefFlakus deleted the fix/145/request-url-parse-error branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.