Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-multipart): wait until whole stream is finished #151

Merged

Conversation

Projects
None yet
2 participants
@JozefFlakus
Copy link
Member

commented Jun 25, 2019

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • the middleware stream is resolved too early when the stream handler is attached

What is the new behavior?

  • the middleware stream is resolved when all streams finish their work

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JozefFlakus JozefFlakus added this to the 2.3.1 milestone Jun 25, 2019

@JozefFlakus JozefFlakus requested a review from krzysztof-miemiec Jun 25, 2019

@JozefFlakus JozefFlakus self-assigned this Jun 25, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         105      105           
  Lines        1347     1347           
  Branches      129      129           
=======================================
  Hits         1346     1346           
  Misses          1        1
Impacted Files Coverage Δ
...kages/middleware-multipart/src/multipart.parser.ts 100% <100%> (ø) ⬆️
.../middleware-multipart/src/multipart.parser.file.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f654b5...1779b46. Read the comment docs.

@JozefFlakus JozefFlakus merged commit 8c246b0 into master Jun 25, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 99.92%)
Details

@JozefFlakus JozefFlakus deleted the fix/middleware-multipart/wait-unit-stream-is-finished branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.