Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): display proper response time #48

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
2 participants
@JozefFlakus
Copy link
Member

commented Jun 11, 2018

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • @marblejs/middleware-logger displays wrong response times

Issue Number: N/A

What is the new behavior?

  • @marblejs/middleware-logger displays proper response times

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JozefFlakus JozefFlakus added the bug label Jun 11, 2018

@JozefFlakus JozefFlakus added this to the v0.5.0 milestone Jun 11, 2018

@JozefFlakus JozefFlakus self-assigned this Jun 11, 2018

@JozefFlakus JozefFlakus requested a review from marblejs/contributors Jun 11, 2018

@JozefFlakus JozefFlakus added this to To do in Roadmap to 1.0.0 via automation Jun 11, 2018

@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2018

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     26    +1     
  Lines         298    302    +4     
  Branches       35     37    +2     
=====================================
+ Hits          298    302    +4
Impacted Files Coverage Δ
packages/middleware-logger/src/time.factory.ts 100% <100%> (ø)
packages/middleware-logger/src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0592e...b59c115. Read the comment docs.

@JozefFlakus JozefFlakus force-pushed the fix/logger-time branch from 1f60b8e to b59c115 Jun 11, 2018

@JozefFlakus JozefFlakus merged commit cab26aa into master Jun 12, 2018

2 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details

Roadmap to 1.0.0 automation moved this from To do to Done Jun 12, 2018

@JozefFlakus JozefFlakus deleted the fix/logger-time branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.