Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(core, websockets, middleware-io): reusable events #91

Merged
merged 8 commits into from Jan 14, 2019

Conversation

Projects
1 participant
@JozefFlakus
Copy link
Member

commented Jan 11, 2019

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

  • @marblejs/middleware-io: removed @marblejs/websockets dependency
  • @marblejs/middleware-io: renamed httpValidator$ to requestValidator$
  • @integration: replaced middleware-joi validator with middleware-io
  • @marblejs/core + @marblejs/websockets: removed websockets related matchType operator in place od reusable across many packages matchEvent operator
  • @marblejs/core: better type inferable ServerEvents
  • @marblejs/core: renamed marble factory function to createServer

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JozefFlakus JozefFlakus added this to the 2.0.0 milestone Jan 11, 2019

@JozefFlakus JozefFlakus self-assigned this Jan 11, 2019

@JozefFlakus JozefFlakus added this to In progress in @marblejs/next via automation Jan 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 11, 2019

Codecov Report

Merging #91 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           next    #91   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        72     74    +2     
  Lines       892    938   +46     
  Branches     84     84           
===================================
+ Hits        892    938   +46
Impacted Files Coverage Δ
packages/websockets/src/operators/index.ts 100% <ø> (ø) ⬆️
packages/websockets/src/websocket.interface.ts 100% <ø> (ø) ⬆️
packages/core/src/http.interface.ts 100% <ø> (ø) ⬆️
packages/websockets/src/error/ws-error.handler.ts 100% <100%> (ø) ⬆️
packages/websockets/src/error/ws-error.model.ts 100% <100%> (ø) ⬆️
packages/core/src/event/event.factory.ts 100% <100%> (ø)
.../src/operators/mapToServer/mapToServer.operator.ts 100% <100%> (ø) ⬆️
packages/core/src/server/server.factory.ts 100% <100%> (ø) ⬆️
...ackages/core/src/server/server.event.subscriber.ts 100% <100%> (ø)
packages/websockets/src/error/ws-error.effect.ts 100% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a07786...da255fe. Read the comment docs.

@JozefFlakus JozefFlakus merged commit 7219b69 into next Jan 14, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details

@marblejs/next automation moved this from In progress to Done Jan 14, 2019

@JozefFlakus JozefFlakus deleted the imp/next/reusable-events branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.