Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): EffectMetadata scheduler #95

Merged
merged 3 commits into from Jan 24, 2019

Conversation

Projects
1 participant
@JozefFlakus
Copy link
Member

commented Jan 23, 2019

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

  • EffectMetadata contains the RxJS Scheduler instance which can be handy for unit-testing Rx streams.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JozefFlakus JozefFlakus added this to the 2.0.0 milestone Jan 23, 2019

@JozefFlakus JozefFlakus self-assigned this Jan 23, 2019

@JozefFlakus JozefFlakus added this to In progress in @marblejs/next via automation Jan 23, 2019

@JozefFlakus JozefFlakus force-pushed the imp/next/metadata-scheduler branch from 2b3bdf6 to e953807 Jan 23, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 23, 2019

Codecov Report

Merging #95 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           next    #95   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        75     76    +1     
  Lines       949    957    +8     
  Branches     84     85    +1     
===================================
+ Hits        949    957    +8
Impacted Files Coverage Δ
...ckages/core/src/effects/effectsMetadata.factory.ts 100% <100%> (ø)
packages/core/src/listener/http.listener.ts 100% <100%> (ø) ⬆️
packages/core/src/server/server.factory.ts 100% <100%> (ø) ⬆️
packages/core/src/index.ts 100% <100%> (ø) ⬆️
...ages/websockets/src/listener/websocket.listener.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11b842...f2804f2. Read the comment docs.

JozefFlakus added some commits Jan 24, 2019

@JozefFlakus JozefFlakus merged commit a5f5a40 into next Jan 24, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details

@marblejs/next automation moved this from In progress to Done Jan 24, 2019

@JozefFlakus JozefFlakus deleted the imp/next/metadata-scheduler branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.