Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware-logger): swapped middleware entrypoints #98

Merged
merged 4 commits into from Jan 31, 2019

Conversation

Projects
1 participant
@JozefFlakus
Copy link
Member

commented Jan 30, 2019

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

  • @marblejs/middleware-logger - swapped loggerWithOpts$ entrypoint with deprecated logger$
  • @marblejs/middlware-body - entrypoint allows to pass configuration object

Does this PR introduce a breaking change?

[x] Yes
[ ] No

@JozefFlakus JozefFlakus added this to the 2.0.0 milestone Jan 30, 2019

@JozefFlakus JozefFlakus self-assigned this Jan 30, 2019

@JozefFlakus JozefFlakus added this to In progress in @marblejs/next via automation Jan 30, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 30, 2019

Codecov Report

Merging #98 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           next    #98   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        76     77    +1     
  Lines       961    961           
  Branches     85     85           
===================================
  Hits        961    961
Impacted Files Coverage Δ
packages/middleware-body/src/index.ts 100% <100%> (ø) ⬆️
packages/middleware-body/src/body.middleware.ts 100% <100%> (ø)
...ackages/middleware-logger/src/logger.middleware.ts 100% <100%> (ø) ⬆️
.../middleware-body/src/body.urlEncoded.serializer.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e888138...f4535ad. Read the comment docs.

@JozefFlakus JozefFlakus merged commit 6324b82 into next Jan 31, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details

@marblejs/next automation moved this from In progress to Done Jan 31, 2019

@JozefFlakus JozefFlakus deleted the imp/next/logger-and-body-entrypoint branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.