This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
feat: enable ECS task monitoring #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwittig
commented
Feb 17, 2023
| @@ -1548,43 +1619,6 @@ resource "aws_cloudwatch_event_target" "ecs_deployment_notifications" { | |||
|
|
|||
|
|
|||
|
|
|||
| resource "aws_cloudwatch_event_rule" "ecs_spot_placement_failure" { | |||
There was a problem hiding this comment.
Rule is a subset of the ecs_service_failed rule
michaelwittig
commented
Feb 17, 2023
|
@andreaswittig please check again |
andreaswittig
approved these changes
Feb 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andreaswittig what do you think? it is partly covered by the ECS service monitoring. But might be still important to detect issues early.