Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
  • 2 commits
  • 3 files changed
  • 0 commit comments
  • 1 contributor
View
2 build.gradle
@@ -20,7 +20,7 @@ dependencies {
group = 'org.gradle.api.plugins'
archivesBaseName = 'gradle-heroku-plugin'
-version = '0.9.4'
+version = '0.9.5'
apply plugin: 'distribution'
View
2 src/main/groovy/org/ratpackframework/gradle/HerokuAppCreateTask.groovy
@@ -32,7 +32,7 @@ class HerokuAppCreateTask extends HerokuTask {
logger.quiet " }"
}
- def buildpackURL = params.buildpack == 'null' ? DEFAULT_BUILDPACK_URL : params.buildpack
+ def buildpackURL = !params.buildpack ? DEFAULT_BUILDPACK_URL : params.buildpack
logger.quiet "Setting buildpack for new application $app.name to $buildpackURL"
configureBuildpack(app.name, buildpackURL)
View
3 src/test/groovy/org/ratpackframework/gradle/HerokuAppCreateSpec.groovy
@@ -2,6 +2,7 @@ package org.ratpackframework.gradle
import com.heroku.api.App
import com.heroku.api.Heroku
import com.heroku.api.HerokuAPI
+import org.codehaus.groovy.runtime.NullObject
import org.gradle.api.Project
import org.gradle.testfixtures.ProjectBuilder
import spock.lang.Specification
@@ -98,7 +99,7 @@ class HerokuAppCreateSpec extends Specification {
task.prepareStoredConfig = { a, b, c -> }
when:
- task.execute([appName: appName, buildpack: 'null'])
+ task.execute([appName: appName, buildpack: new NullObject()])
then:
herokuAPI.createApp(_) >> app

No commit comments for this range

Something went wrong with that request. Please try again.