Patch for working with ruby 2.5+ #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks @ngoral ❤️ |
|
Thanks for the patch. |
Since ruby 2.5 +write+ accepts more than one argument. Concider everyone calls +to_s+ on Hashes and Symbols
ngoral
force-pushed
the
patch_for_ruby_2_5_and_higher
branch
from
85bf430
to
bb9fd45
Compare
|
@marcandre I reconsidered the patch a bit. We now make a small consideration but unlike the previous version, this one won't break default writing to pipes |
|
I'm ok to merge this. The ideal patch in my opinion would be to use refinements instead for the method(s) that are now incompatible (or can potentially be). IIRC these cheats are not even needed anyways, right? |
|
Released v1.3.11 Are you up to writing a PR where either |
|
Sorry, I reverted my mistake 🤦♂️ and excluded TTYs instead. v1.3.13 released |
akimd
added a commit
to akimd/packable
that referenced
this pull request
Jun 16, 2020
I believe this is closely related to marcandre#12: not all the streams are seekable. Unfortunately not all the non-tty streams are seekable too, pipes are a problem. So instead of checking if the stream is not a tty, let's use minitar's seekable? test.
akimd
added a commit
to akimd/packable
that referenced
this pull request
Jun 16, 2020
I believe this is closely related to marcandre#12: not all the streams are seekable. Unfortunately not all the non-tty streams are seekable too, pipes are a problem. So instead of checking if the stream is not a tty, let's use minitar's seekable? test.
akimd
added a commit
to akimd/packable
that referenced
this pull request
Jun 16, 2020
I believe this is closely related to marcandre#12: not all the streams are seekable. Unfortunately not all the non-tty streams are seekable too, pipes are a problem. So instead of checking if the stream is not a tty, let's use minitar's seekable? test.
akimd
added a commit
to akimd/packable
that referenced
this pull request
Jun 16, 2020
I believe this is closely related to marcandre#12: not all the streams are seekable. Unfortunately not all the non-tty streams are seekable too, pipes are a problem. So instead of checking if the stream is not a tty, let's use minitar's seekable? test.
akimd
added a commit
to akimd/packable
that referenced
this pull request
Jun 16, 2020
I believe this is closely related to marcandre#12: not all the streams are seekable. Unfortunately not all the non-tty streams are seekable too, pipes are a problem. So instead of checking if the stream is not a tty, let's use minitar's seekable? test.
marcandre
pushed a commit
that referenced
this pull request
Jun 16, 2020
See #12 Adapted from minitar's seekable? test.
marcandre
pushed a commit
that referenced
this pull request
Jun 16, 2020
See #12 Adapted from minitar's seekable? test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch fixing illegal seek issue on Linux with Ruby 2.5 and higher