New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the options passed to S3Object.copy, supporting reduced redundancy #44

Merged
merged 1 commit into from Nov 9, 2011

Conversation

Projects
None yet
2 participants
@mcary

mcary commented Nov 9, 2011

I need to enable reduced redundancy on some existing S3 objects.
The typical way to do this is copy the object within S3, supplying the
new storage-class (reduced redundancy) as an option to the copy.
However, aws-s3 is ignoring the copy options, instead only using the
default_options to specify the copy-source.

Update the copy method to merge the copy-source options with the passed
options, so that storage-class can be specified.

Marcel M. Cary
Use the options passed to S3Object.copy, supporting reduced redundancy
I need to enable reduced redundancy on some existing S3 objects.
The typical way to do this is copy the object within S3, supplying the
new storage-class (reduced redundancy) as an option to the copy.
However, aws-s3 is ignoring the copy options, instead only using the
default_options to specify the copy-source.

Update the copy method to merge the copy-source options with the passed
options, so that storage-class can be specified.

marcel added a commit that referenced this pull request Nov 9, 2011

Merge pull request #44 from mcary/use-copy-options
Merge in options passed to S3Object.copy.

@marcel marcel merged commit 1ec3ff9 into marcel:master Nov 9, 2011

@marcel

This comment has been minimized.

Show comment
Hide comment
@marcel

marcel Nov 9, 2011

Owner

Simple fix. Proper test. Perfect. Merged. Thanks.

Owner

marcel commented Nov 9, 2011

Simple fix. Proper test. Perfect. Merged. Thanks.

@mcary

This comment has been minimized.

Show comment
Hide comment
@mcary

mcary Nov 10, 2011

Thanks for the quick turn-around. (:

mcary commented Nov 10, 2011

Thanks for the quick turn-around. (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment