Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support x64 (automatic detection) #16

Closed
marcelklehr opened this Issue Sep 16, 2012 · 5 comments

Comments

Projects
None yet
3 participants
Owner

marcelklehr commented Sep 16, 2012

Detect x64 automatically

Contributor

branneman commented Dec 2, 2013

+1

This is buggy still as you can't switch back to 32 bit:

screen shot 2014-01-13 at 7 13 11 pm

Fix I think is 134eea0#commitcomment-5058502 but would also likely be needed at https://github.com/marcelklehr/nodist/blob/master/lib/nodist.js#L45

Owner

marcelklehr commented Jan 14, 2014

mh. Actually I think I left it up to the consumer of the nodist library to implement x64 detection/option, so the critical line would be in here: https://github.com/marcelklehr/nodist/blob/master/cli.js#L64.

In nodist.js it adapts the path to the sourceDir (where versions are stored), based on wantX64: https://github.com/marcelklehr/nodist/blob/master/lib/nodist.js#L45

@marcelklehr marcelklehr reopened this Jan 14, 2014

Owner

marcelklehr commented Jan 14, 2014

Yea, the ciritcal thing is type coercion in js. I either assumed we get the value of the env var as a number or that '0' ^= false, which is both wrong.

Owner

marcelklehr commented Jan 14, 2014

fixed in v0.4.3. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment