Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable (partially) to work under non-ASCII path on Windows. #483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@Suzumizaki
Copy link
Contributor

@Suzumizaki Suzumizaki commented Jul 12, 2019

Consider building under virtual environments made by venv which contains non-ASCII characters.

Especially, the default user name often contains that characters under non-English mode Windows. That means the full path of "Documents" or "Desktop" etc. possibly be contain such characters.

In fact, due to using imagehlp.h functions, this is partial solution. For example, under en-US environment, this patch affects nothing. Another example, when using Japanese mode Windows and using characters that is not included cp932, this patch would help none.

But this patch would much better user experience, because at least they can use their native characters.

@Suzumizaki
Copy link
Contributor Author

@Suzumizaki Suzumizaki commented Aug 13, 2019

... Sorry, I made something wrong. I'll re-fix later.

Loading

@Suzumizaki Suzumizaki force-pushed the enable_under_non_ascii_path branch 3 times, most recently from 2ac07ae to c8f39bb Aug 13, 2019
Consider building under virtual environments made by venv which contains non-ASCII characters.

Especially, the default user name often contains that characters under non-English mode Windows. That means the full path of "Documents" or "Desktop" etc. possibly  be contain such characters.

In fact, due to using imagehlp.h functions, this is partial solution. For example, under en-US environment, this patch affects nothing. Another example, when using Japanese mode Windows and using characters that is *not* included cp932, this patch would help none.

But this patch would much better user experience, because at least they can use their native characters.
@Suzumizaki Suzumizaki force-pushed the enable_under_non_ascii_path branch from c8f39bb to 37d746a Aug 13, 2019
@Suzumizaki
Copy link
Contributor Author

@Suzumizaki Suzumizaki commented Aug 13, 2019

... I finished fix to catch up master branch. Thank you.

Loading

Base automatically changed from master to main Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant