Enable (partially) to work under non-ASCII path on Windows.#483
Closed
Suzumizaki wants to merge 1 commit into
Closed
Enable (partially) to work under non-ASCII path on Windows.#483Suzumizaki wants to merge 1 commit into
Suzumizaki wants to merge 1 commit into
Conversation
Contributor
Author
|
... Sorry, I made something wrong. I'll re-fix later. |
Suzumizaki
force-pushed
the
enable_under_non_ascii_path
branch
3 times, most recently
from
2ac07ae to
c8f39bb
Compare
Consider building under virtual environments made by venv which contains non-ASCII characters. Especially, the default user name often contains that characters under non-English mode Windows. That means the full path of "Documents" or "Desktop" etc. possibly be contain such characters. In fact, due to using imagehlp.h functions, this is partial solution. For example, under en-US environment, this patch affects nothing. Another example, when using Japanese mode Windows and using characters that is *not* included cp932, this patch would help none. But this patch would much better user experience, because at least they can use their native characters.
Suzumizaki
force-pushed
the
enable_under_non_ascii_path
branch
from
c8f39bb to
37d746a
Compare
Contributor
Author
|
... I finished fix to catch up master branch. Thank you. |
Owner
|
In some PR I solved problems with names in UTF-8 on Windows and Linux. And as this PR is very old, and the code is different, I will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider building under virtual environments made by venv which contains non-ASCII characters.
Especially, the default user name often contains that characters under non-English mode Windows. That means the full path of "Documents" or "Desktop" etc. possibly be contain such characters.
In fact, due to using imagehlp.h functions, this is partial solution. For example, under en-US environment, this patch affects nothing. Another example, when using Japanese mode Windows and using characters that is not included cp932, this patch would help none.
But this patch would much better user experience, because at least they can use their native characters.