Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rest dialyzer warnings #7

Merged
merged 3 commits into from Mar 10, 2020

Conversation

@rustra
Copy link
Contributor

rustra commented Mar 10, 2020

Please look at #5.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2020

Coverage Status

Coverage remained the same at 70.932% when pulling 8115554 on rustra:fix_dialyzer_warnings into 2244c36 on marcelotto:master.

@rustra rustra mentioned this pull request Mar 10, 2020
Copy link
Owner

marcelotto left a comment

Awesome.

lib/rdf/serialization/decoder.ex Outdated Show resolved Hide resolved
lib/rdf/datatypes/boolean.ex Outdated Show resolved Hide resolved

@type value :: boolean
@type input :: value | String.t | number

This comment has been minimized.

Copy link
@marcelotto

marcelotto Mar 10, 2020

Owner

Instead of having always value | input | Literal.t | any on the input arguments below, I would add Literal.t | any here. Similar in the other datatype definitions.

This comment has been minimized.

Copy link
@rustra

rustra Mar 10, 2020

Author Contributor

No objections, changed.

@rustra

This comment has been minimized.

Copy link
Contributor Author

rustra commented Mar 10, 2020

Just to remind: please update the library version after this merge, to use your wonderful library without Dialyzer warnings! :)

@marcelotto marcelotto merged commit 625cec9 into marcelotto:master Mar 10, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.932%
Details
@rustra

This comment has been minimized.

Copy link
Contributor Author

rustra commented Mar 11, 2020

🖤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.