New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure namespace is not None before comparison #240

Merged
merged 1 commit into from Mar 26, 2015

Conversation

Projects
None yet
2 participants
@pquentin
Contributor

pquentin commented Mar 19, 2015

None in ['something'] raises a TypeError, and Django URL namespaces can be None.

@pquentin

This comment has been minimized.

Show comment
Hide comment
@pquentin

pquentin Mar 23, 2015

Contributor

Updated to use the foo is not None idiomatic check instead of just if not foo. None is indeed the value Django uses when no pattern exists, see https://github.com/django/django/blob/master/django/core/urlresolvers.py#L252

This prevents us from using django-rest-swagger right now. Anything I can do to get this merged? @ariovistus, it looks like you were recently active, I'd love to hear from you to improve this pull request.

Contributor

pquentin commented Mar 23, 2015

Updated to use the foo is not None idiomatic check instead of just if not foo. None is indeed the value Django uses when no pattern exists, see https://github.com/django/django/blob/master/django/core/urlresolvers.py#L252

This prevents us from using django-rest-swagger right now. Anything I can do to get this merged? @ariovistus, it looks like you were recently active, I'd love to hear from you to improve this pull request.

ariovistus added a commit that referenced this pull request Mar 26, 2015

Merge pull request #240 from pquentin/patch-exclude
Ensure namespace is not None before comparison

@ariovistus ariovistus merged commit 4fe2215 into marcgibbons:master Mar 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ariovistus

This comment has been minimized.

Show comment
Hide comment
@ariovistus

ariovistus Mar 26, 2015

Collaborator

sorry bout that, been busy

Collaborator

ariovistus commented Mar 26, 2015

sorry bout that, been busy

@pquentin

This comment has been minimized.

Show comment
Hide comment
@pquentin

pquentin Mar 26, 2015

Contributor

Thank you @ariovistus!

Contributor

pquentin commented Mar 26, 2015

Thank you @ariovistus!

@pquentin pquentin deleted the pquentin:patch-exclude branch Mar 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment