Bumped send_file() to HTTP/1.1, added missing zero-length chunk at the end #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with this on my ESP32 and
curl
was giving output like this:It turns out there were two issues, one is that chunked encoding is available in HTTP/1.1, not 1.0, and it requires a final zero-length chunk to indicate there's no more.
(As an aside, thanks so much for this repo, it's been invaluable in getting my head around how to use
uasyncio
to create a super-basic HTTP server!)