Skip to content

[winget] In case on missing winget, the confirmation message is misleading #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcinotorowski opened this issue Feb 16, 2021 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@marcinotorowski
Copy link
Owner

In winget editor, after saving a package a validation with Winget CLI is performed. In case of missing winget (not yet installed) the message says that the validation might have failed. This must be resolved in one of the following ways:

a) change the validation message to say that the package could not be validated due to missing winget, or
b) (preferred) skip winget CLI validation if there is no winget on the machine.

The second approach was originally implemented, but seems to be a regression in 2.x.

@marcinotorowski marcinotorowski added the enhancement New feature or request label Feb 16, 2021
@marcinotorowski marcinotorowski added the bug Something isn't working label Feb 17, 2021
@marcinotorowski
Copy link
Owner Author

Bug with winget detection has been fixed, additionally the following UI changes were done:

image

After expanding:

image

Confirmation screen:

image

@marcinotorowski
Copy link
Owner Author

@marcinotorowski marcinotorowski self-assigned this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant