Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bots: Allow admin to resume where a failed botrun left of #30

Closed
MarcKaufmann opened this issue Feb 17, 2021 · 1 comment
Closed

Bots: Allow admin to resume where a failed botrun left of #30

MarcKaufmann opened this issue Feb 17, 2021 · 1 comment
Assignees
Labels
async enhancement New feature or request

Comments

@MarcKaufmann
Copy link
Owner

It is pretty tedious to debug bots currently, as one has to navigate to the page to find out what went wrong if it is an HTML/JS/CSS issue. Would be nice to be able to resume a bot user as admin or some such.

@MarcKaufmann MarcKaufmann added async enhancement New feature or request labels Feb 17, 2021
Bogdanp added a commit that referenced this issue Feb 20, 2021
@MarcKaufmann
Copy link
Owner Author

Nice, especially that it works for all users. However, we now need a way to stop impersonating that user and return to normal admin mode, hence I reopen the issue. Looking at the code, it seems like you are setting the id of the session-cookie to that of the person being impersonated, in which case that won't allow jumping back to admin afterwards. Currently, getting back to admin requires logging out after impersonating and then logging in again as admin. Is that single direction intended? It would be nice to have a smoother way to get back to admin.

Maybe if session-key was a list, with the head used as session-key, and only admins can add to the front of session-keys by impersonating? Then one can go back to admin by dropping the head. session-key is probably too general, so session-impersonator-key as the key of the original impersonator might work.

Another issue: it doesn't seem right to allow admins to impersonate other admins -- or can you imagine a use case? I am worried that one admin can take actions for another, and it is impossible to tell the two apart.

@MarcKaufmann MarcKaufmann reopened this Feb 26, 2021
@Bogdanp Bogdanp closed this as completed in b854f1f Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants