From bf27e6a917233d1f138fb691dc6120cf075a278f Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Thu, 3 Oct 2019 08:15:29 +0000 Subject: [PATCH] Bug 1474317: Make text-orientation, unicode-bidi, contain and will-change non-animatable. r=heycam Per recent CSSWG resolutions: https://github.com/w3c/csswg-drafts/issues/2737 https://github.com/w3c/csswg-drafts/issues/2751 Differential Revision: https://phabricator.services.mozilla.com/D3888 UltraBlame original commit: 4bb2acbf4eb0d386046945e52bdd546fc41ae8e5 --- .../style/properties/longhands/box.mako.rs | 20 ++++++++------- .../longhands/inherited_box.mako.rs | 5 +--- .../style/properties/longhands/text.mako.rs | 12 +++++---- ...ocessing-a-keyframes-argument-001.html.ini | 25 ------------------- 4 files changed, 19 insertions(+), 43 deletions(-) delete mode 100644 testing/web-platform/meta/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html.ini diff --git a/servo/components/style/properties/longhands/box.mako.rs b/servo/components/style/properties/longhands/box.mako.rs index d2039bed7f5ce..0e7061b6e96e2 100644 --- a/servo/components/style/properties/longhands/box.mako.rs +++ b/servo/components/style/properties/longhands/box.mako.rs @@ -513,14 +513,16 @@ ${helpers.predefined_type( servo_restyle_damage="reflow_out_of_flow" )} -${helpers.predefined_type("contain", - "Contain", - "specified::Contain::empty()", - animation_value_type="discrete", - products="gecko", - flags="CREATES_STACKING_CONTEXT FIXPOS_CB", - gecko_pref="layout.css.contain.enabled", - spec="https://drafts.csswg.org/css-contain/#contain-property")} +${helpers.predefined_type( + "contain", + "Contain", + "specified::Contain::empty()", + animation_value_type="none", + products="gecko", + flags="CREATES_STACKING_CONTEXT FIXPOS_CB", + gecko_pref="layout.css.contain.enabled", + spec="https://drafts.csswg.org/css-contain/#contain-property", +)} // Non-standard ${helpers.predefined_type( @@ -552,7 +554,7 @@ ${helpers.predefined_type( "WillChange", "computed::WillChange::auto()", products="gecko", - animation_value_type="discrete", + animation_value_type="none", spec="https://drafts.csswg.org/css-will-change/#will-change" )} diff --git a/servo/components/style/properties/longhands/inherited_box.mako.rs b/servo/components/style/properties/longhands/inherited_box.mako.rs index 5dd30c440f06c..a6ac4427feea0 100644 --- a/servo/components/style/properties/longhands/inherited_box.mako.rs +++ b/servo/components/style/properties/longhands/inherited_box.mako.rs @@ -40,15 +40,12 @@ ${helpers.single_keyword( servo_restyle_damage="rebuild_and_reflow", )} -// TODO(emilio): Should text-orientation be non-animatable? It affects the -// WritingMode value, but not the logical -> physical mapping of properties, -// which is the reason direction / writing-mode are non-animatable. ${helpers.single_keyword( "text-orientation", "mixed upright sideways", extra_gecko_aliases="sideways-right=sideways", products="gecko", - animation_value_type="discrete", + animation_value_type="none", spec="https://drafts.csswg.org/css-writing-modes/#propdef-text-orientation", )} diff --git a/servo/components/style/properties/longhands/text.mako.rs b/servo/components/style/properties/longhands/text.mako.rs index 18eaf21d215c3..5907153721524 100644 --- a/servo/components/style/properties/longhands/text.mako.rs +++ b/servo/components/style/properties/longhands/text.mako.rs @@ -21,11 +21,13 @@ ${helpers.predefined_type("text-overflow", spec="https://drafts.csswg.org/css-ui/#propdef-text-overflow", servo_restyle_damage="rebuild_and_reflow")} -${helpers.single_keyword("unicode-bidi", - "normal embed isolate bidi-override isolate-override plaintext", - animation_value_type="discrete", - spec="https://drafts.csswg.org/css-writing-modes/#propdef-unicode-bidi", - servo_restyle_damage="rebuild_and_reflow")} +${helpers.single_keyword( + "unicode-bidi", + "normal embed isolate bidi-override isolate-override plaintext", + animation_value_type="none", + spec="https://drafts.csswg.org/css-writing-modes/#propdef-unicode-bidi", + servo_restyle_damage="rebuild_and_reflow", +)} ${helpers.predefined_type("text-decoration-line", "TextDecorationLine", diff --git a/testing/web-platform/meta/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html.ini b/testing/web-platform/meta/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html.ini deleted file mode 100644 index fbfba92d485a4..0000000000000 --- a/testing/web-platform/meta/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html.ini +++ /dev/null @@ -1,25 +0,0 @@ -[processing-a-keyframes-argument-001.html] - [non-animatable property 'contain' is not accessed when using a property-indexed keyframe object] - expected: FAIL - - [non-animatable property 'textOrientation' is not accessed when using a property-indexed keyframe object] - expected: FAIL - - [non-animatable property 'unicodeBidi' is not accessed when using a property-indexed keyframe object] - expected: FAIL - - [non-animatable property 'willChange' is not accessed when using a property-indexed keyframe object] - expected: FAIL - - [non-animatable property 'contain' is not accessed when using a keyframe sequence] - expected: FAIL - - [non-animatable property 'textOrientation' is not accessed when using a keyframe sequence] - expected: FAIL - - [non-animatable property 'unicodeBidi' is not accessed when using a keyframe sequence] - expected: FAIL - - [non-animatable property 'willChange' is not accessed when using a keyframe sequence] - expected: FAIL -