From e0447c6de83653a8a9ba91fe89e69f8173d75c64 Mon Sep 17 00:00:00 2001 From: Marco Castelluccio Date: Wed, 8 Nov 2023 15:40:21 +0000 Subject: [PATCH] Bug 1861071 [wpt PR 42746] - Revert "Give element default unicode-bidi: isolate style.", a=testonly Automatic update from web-platform-tests Revert "Give element default unicode-bidi: isolate style." This reverts commit 198d41cfd6eac5fd9ee34e6314e34f938b6d31b5. Reason for revert: This reverts a change that was the first of two closely related changes. Given that the other change, in https://crrev.com/c/4973701, turned out to have problems (and I haven't attempted to land it), I've proposed reverting both in the HTML spec at https://github.com/whatwg/html/pull/9880. I'm therefore reverting this (the first half) until the HTML spec discussion is sorted out. Original change's description: > Give element default unicode-bidi: isolate style. > > This is behind the RuntimeEnabledFeatures::CSSPseudoDirEnabled() flag. > > This implements a part of the behavior described in: > https://github.com/whatwg/html/issues/3699#issuecomment-951423468 > which has been specified in: > https://github.com/whatwg/html/pull/9554 > https://github.com/whatwg/html/pull/9796 > > Bug: 576815 > Change-Id: Ice471838c7251fc69d87abfa723f3eef1a4c455a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4800075 > Reviewed-by: Chris Harrelson > Reviewed-by: Di Zhang > Commit-Queue: David Baron > Cr-Commit-Position: refs/heads/main{#1214439} Bug: 576815 Change-Id: I0f52b30c345d4962a36a36e5d2651221db96bcde No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4974023 Reviewed-by: Philip Rogers Bot-Commit: Rubber Stamper Auto-Submit: David Baron Commit-Queue: Philip Rogers Cr-Commit-Position: refs/heads/main{#1215009} -- wpt-commits: 8cc01fc73b14dcbc92109574c26d85b25f5cfba0 wpt-pr: 42746 UltraBlame original commit: 4f46a8fcb456fa55fd784b0714da59ad7b206c79 --- .../bidi-rendering/slot-isolate-001-ref.html | 118 ------- .../bidi-rendering/slot-isolate-001.html | 299 ------------------ 2 files changed, 417 deletions(-) delete mode 100644 testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001-ref.html delete mode 100644 testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001.html diff --git a/testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001-ref.html b/testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001-ref.html deleted file mode 100644 index 4b8fee0464fe..000000000000 --- a/testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001-ref.html +++ /dev/null @@ -1,118 +0,0 @@ -< -! -DOCTYPE -html -> -< -title -> -HTML -Rendering -: -slot -element -has -unicode -- -bidi -: -isolate -< -/ -title -> -< -link -rel -= -" -author -" -title -= -" -L -. -David -Baron -" -href -= -" -https -: -/ -/ -dbaron -. -org -/ -" -> -< -link -rel -= -" -author -" -title -= -" -Google -" -href -= -" -http -: -/ -/ -www -. -google -. -com -/ -" -> -< -div -style -= -" -unicode -- -bidi -: -bidi -- -override -; -direction -: -ltr -; -" -> -& -# -x5D0 -; -- -& -# -x5D1 -; -< -/ -div -> -< -div -> -isolate -< -/ -div -> diff --git a/testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001.html b/testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001.html deleted file mode 100644 index 241b90969182..000000000000 --- a/testing/web-platform/tests/html/rendering/bidi-rendering/slot-isolate-001.html +++ /dev/null @@ -1,299 +0,0 @@ -< -! -DOCTYPE -html -> -< -title -> -HTML -Rendering -: -slot -element -has -unicode -- -bidi -: -isolate -< -/ -title -> -< -link -rel -= -" -author -" -title -= -" -L -. -David -Baron -" -href -= -" -https -: -/ -/ -dbaron -. -org -/ -" -> -< -link -rel -= -" -author -" -title -= -" -Google -" -href -= -" -http -: -/ -/ -www -. -google -. -com -/ -" -> -< -link -rel -= -" -help -" -href -= -" -https -: -/ -/ -html -. -spec -. -whatwg -. -org -/ -multipage -/ -rendering -. -html -# -bidi -- -rendering -" -> -< -link -rel -= -" -help -" -href -= -" -https -: -/ -/ -github -. -com -/ -whatwg -/ -html -/ -pull -/ -9796 -" -> -< -link -rel -= -" -match -" -href -= -" -slot -- -isolate -- -001 -- -ref -. -html -" -> -< -div -> -& -# -x5D0 -; -- -< -span -id -= -" -e -" -> -& -# -x5D1 -; -< -/ -span -> -< -/ -div -> -< -div -id -= -" -v -" -> -< -/ -div -> -< -script -> -let -e -= -document -. -getElementById -( -" -e -" -) -; -let -root -= -e -. -attachShadow -( -{ -mode -: -" -open -" -} -) -; -/ -/ -use -display -: -inline -to -override -default -display -: -contents -root -. -innerHTML -= -" -< -slot -style -= -' -display -: -inline -' -> -\ -u05D2 -< -/ -slot -> -" -; -let -val -= -getComputedStyle -( -root -. -querySelector -( -" -slot -" -) -) -. -unicodeBidi -; -document -. -getElementById -( -" -v -" -) -. -innerText -= -val -; -< -/ -script ->