Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use right room dimensions in graphs #85

Closed
marcomicera opened this issue Jan 5, 2020 · 2 comments
Closed

Use right room dimensions in graphs #85

marcomicera opened this issue Jan 5, 2020 · 2 comments
Labels
frontend Code concerning the core's UI

Comments

@marcomicera
Copy link
Owner

marcomicera commented Jan 5, 2020

As @SelyBarguest pointed out in #83:

The chart dimensions are based on the boards and not the device room. In this example the room is bigger then the rectangle created by the boards.

We might wanna postpone this to debug our localization algorithm and solve this issue once we are sure that no device within the room is actually displayed outside.

@marcomicera marcomicera added the frontend Code concerning the core's UI label Jan 5, 2020
@marcomicera marcomicera added this to the Soft requirements milestone Jan 5, 2020
@marcomicera marcomicera mentioned this issue Jan 5, 2020
3 tasks
@marcomicera marcomicera changed the title Radar: right room dimensions Use right room dimensions in graphs Jan 10, 2020
@marcomicera marcomicera pinned this issue Jan 10, 2020
@marcomicera
Copy link
Owner Author

Update: #89 must be done first.
Then, I'd go for setting the room dimensions in

  1. Radar
  2. Timeline

plus some hardcoded extra centimeters (e.g., +100cm should be enough) for debugging purposes (so we can see devices outside the room).

@marcomicera marcomicera unpinned this issue Jan 10, 2020
@marcomicera
Copy link
Owner Author

Solved in cd5dba9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Code concerning the core's UI
Projects
None yet
Development

No branches or pull requests

1 participant