Null color picker #24
Conversation
There was a problem hiding this comment.
Nice! Looks really clean 👍
I'll make sure to test this during the weekend so we can get this merged! In the meantime, would you mind adding docs for this in the README?
Also, did you make any changes to the .gitignore? Seems to be only whitespace changes? If this was unintentional, could you revert it?
| @@ -97,6 +97,11 @@ export const plugin = getPanelPluginOrFallback( | |||
| showIf: (config: HeatmapFieldConfig) => | |||
| config.colorPalette !== 'custom' && config.colorPalette !== 'fieldOptions', | |||
| }) | |||
| .addColorPicker({ | |||
There was a problem hiding this comment.
We need to check in which version of Grafana the color picker option was added. Currently, the plugin can run on >=7.0.3, but we might need to bump the required minimum required version depending on when this was introduced.
Co-authored-by: Marcus Olsson <marcus.olsson@hey.com>
|
Thank you! I added a description into the README and reverted the .gitignore changes, they were unintentional. |
There was a problem hiding this comment.
I've tested this and it seems to work great even on 7.0.3, so no version bump needed! 🎉
It seems like your editor might change the whitespace in the edited files (like the README.md and gitignore). Are you perhaps using Windows? I'm not entirely sure, but your git client might be set up to commit Windows-style line endings.
I recommend that you look into it to make it easier to work on cross-platform projects. But if you don't have the time to look into it right now, you could revert the README.md changes and I'll add your docs update in a separate commit.
Can't wait to merge this!
|
Hi! Yes I am on Windows, I forgot to change the settings for the line endings. Sorry about that! I just fixed it and pushed. |
Allows you to choose what color is used to fill buckets in the heatmap that have NO data as opposed to data values of 0.