GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This is a follow on to my first pull request that upgrades to the latest version of std, it seems to work.
package.json: add std to dependencies
if you add kafka as a dependency to a project it doesn't work because
std is missing, if you install the latest std it doesn't work because
_init is now init via std commit 02e278b0.
Start by fixing up the dependency in the package.json.
lib: upgrade to latest std version
_init is now init in std thanks to 02e278b0. update all of the usages.
node_modules: stop including std
including std in node_modules is no longer needed since it is installed
via package.json, remove it.
Merge pull request #6 from philips/upgrade-to-latest-std
Upgrade to latest std
Great stuff - thanks man!
just pushed latest std v0.1.28 and kafka v0.2.1 to the npm repo.
Thanks again for taking the time to fix this!
Enough people seem to be using the lib that it may be time to get unit tests going to avoid breakage.
Thanks for merging these so quickly. Looking forward to playing around with node-kafka.