Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

store.js incompatible with QUnit.js #88

Closed
benrudolph opened this Issue · 3 comments

2 participants

@benrudolph

Unfortunately, QUnit.js actually has an object called module with a property exports and thus store.js gets confused on this check:

if (typeof module != 'undefined' && module.exports)

And storejs thinks it's in a node environment, which it is not. This answer on SO seems to be a good way to fix it: http://stackoverflow.com/a/11918368/835696

@benrudolph benrudolph referenced this issue from a commit in benrudolph/store.js
@benrudolph benrudolph (#88) - Fix nodejs check bee4bf1
@marcuswestin
Owner
@benrudolph

Agreed, a PR has been submitted, but with no valid justification. I'll write one up tonight and post it.

@marcuswestin

Fixed in #89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.