Fix threading issue

marczych · Jul 5, 2012 · fc62282 · fc62282
1 parent eda865d
commit fc62282
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/library/src/com/ifixit/android/imagemanager/ImageManager.java b/library/src/com/ifixit/android/imagemanager/ImageManager.java
@@ -254,22 +254,24 @@ private void writeFile(Bitmap bitmap, String url) {
    }
 
    private void storeImage(String url, Bitmap bitmap) {
-      StoredBitmap storedBitmap = new StoredBitmap(null, url);
-      int index = mRecentImages.indexOf(storedBitmap);
+      synchronized (mRecentImages) {
+         StoredBitmap storedBitmap = new StoredBitmap(null, url);
+         int index = mRecentImages.indexOf(storedBitmap);
 
-      // Already in list, lets move it to the front
-      if (index != -1) {
-         storedBitmap = mRecentImages.get(index);
-         mRecentImages.remove(index);
-      } else {
-         storedBitmap.mBitmap = bitmap;
-      }
+         // Already in list, lets move it to the front
+         if (index != -1) {
+            storedBitmap = mRecentImages.get(index);
+            mRecentImages.remove(index);
+         } else {
+            storedBitmap.mBitmap = bitmap;
+         }
 
-      while (mRecentImages.size() >= mMaxStoredImages) {
-         mRecentImages.removeLast();
-      }
+         while (mRecentImages.size() >= mMaxStoredImages) {
+            mRecentImages.removeLast();
+         }
 
-      mRecentImages.addFirst(new StoredBitmap(bitmap, url));
+         mRecentImages.addFirst(new StoredBitmap(bitmap, url));
+      }
    }
 
    private class StoredBitmap {