Add PHP-FPM dashboard #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose prometheus metrics and add Grafana dashboard. The Metrics endpoint is not yet protected.
The environment variable APP_METRICS_ALLOWED_IPS can take a comma-separated list of ip addresses. Additionally, APP_TRUSTED_PROXIES can be configured. This is needed because when run, e.g., in a docker environment, the allowed ips for metrics can cover the whole ip address range of docker. If the load balancer runs within the same range, it would always be allowed to access the metrics endpoint. With trusted proxies, it would forward the client's ip address, which at the end would be rejected.
10 tasks
Open metrics endpoint to any client for simplicity to not maintain the whole ip range of docker on a non-live system.
marein
force-pushed
the
130-add-php-fpm-dashboard
branch
from
96d49a3
to
e7b55b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance decreases by a good amount with this pull request. Tested on a server that can handle
4500 req/s, the same server with this pull request applied can handle only3800 req/s. This is probably because of lock contention. If there would be more fpm instances with lower workers instead of one fpm instance with a lot of workers, the contention is lower. Another possibility would be to store the pid as part of the metric and merge them back when querying Prometheus, then the locks are completely gone, however, with the downside of having a higher cardinality.